simple contact form emailer not working

[sshelp001]

hi, i made a simple contact form that doesnt post all the data in my email. any help greatly apprectiated. the part that doesnt show up is "phone" also, the receipt page echo is just echoing "your message has been sent to...etc" and its not echoing the $subject or $body.thank you. derek EDIT-nevermind, i got "phone" to work, but the $subject and $body still does not echo. (also, someone just told me that a hacker could change my code or variables. is there something i can do to stop this?)

here is the html for the form.

Code:

<form id="flowers_form" name="flowers_form" method="post" action="flowers_emailer.php">
     <div><label for="message">Send us a message</label><textarea name="message" id="message" cols="30" rows="10"></textarea>
     </div>
     <div><label for="name">Name</label><input name="name" id="name" type="text"></input></div>
     <div><label for="phone">Phone</label><input phone="phone" id="phone" type="text"></input></div>
     <div><label for="email">Email</label><input email="email" id="email" type="text"></input></div>
     <div>Select Location:<select name="location" id="location">
              <option id="location" name="location" value="nj_fortlee">NJ - Fort Lee</option>
         <option id="location" name="location" value="nj_jerseycity">NJ - Jersey City</option>
         <option id="location" name="location" value="nj_princeton">NJ - Princeton</option>
         <option id="location" name="location" value="nj_shorthills">NJ - Short Hills </option>
         <option id="location" name="location" value="nj_brid">NJ - Bridgewater</option>
         <option id="location" name="location" value="nj_eastbrunswick">NJ - East Brunswick</option>
         <option id="location" name="location" value="nj_newark">NJ - Newark</option>
         <option id="location" name="location" value="nj_iselin">NJ - Iselin</option>
         <option id="location" name="location" value="nj_lawrenceville">NJ - Lawrenceville</option>
         <option id="location" name="location" value="nj_mahwah">NJ - Mahwah</option>
         <option id="location" name="location" value="nj_morriston">NJ - Morristown</option>
         <option id="location" name="location" value="nj_mtlaurel">NJ - Mt. Laurel</option>
         <option id="location" name="location" value="nj_parsippany">NJ - Parsippany</option>
         <option id="location" name="location" value="nj_redbank">NJ - Red Bank</option>
         <option id="location" name="location" value="nj_roseland">NJ - Roseland</option>
         <option id="location" name="location" value="nj_saddlebrook">NJ - Saddle Brook</option>
         <option id="location" name="location" value="nj_piscataway">NJ - Piscataway</option>
         <option id="location" name="location" value="ny_nyc">NY - New York City</option>
         <option id="location" name="location" value="ny_rye">NY - Rye</option>
         <option id="location" name="location" value="ny_tarrytown">NY - Tarrytown</option>
         <option id="location" name="location" value="ny_whiteplains">NY - White Plains</option>
         <option id="location" name="location" value="ny_bohemia">NY - Bohemia</option>
         <option id="location" name="location" value="ny_hauppauqe">NY - Hauppauqe</option>
         <option id="location" name="location" value="ny_lakesuccess">NY - Lake Success</option>
         <option id="location" name="location" value="ny_melville">NY - Melville</option>
         <option id="location" name="location" value="ny_syosset">NY - Syosset</option>
         <option id="location" name="location" value="ny_uniondale">NY - Uniondale</option>
         <option id="location" name="location" value="ct_greenwich">CT - Greenwich</option>
         <option id="location" name="location" value="ct_stamford">CT - Stamford</option>
         <option id="location" name="location" value="ca_losangeles">CA - Los Angeles</option>
         <option id="location" name="location" value="ca_sanfrancisco">CA - San Francisco</option>
         <option id="location" name="location" value="fl_miami">FL - Miami</option>
         <option id="location" name="location" value="fl_orlando">FL - Orlando</option>
         <option id="location" name="location" value="fl_fortlauderdale">FL - Fort Lauderdale</option>
         <option id="location" name="location" value="fl_palmbeach">FL - Palm Beach</option>
         <option id="location" name="location" value="dc_washington">DC - Washington</option>
         <option id="location" name="location" value="pa_philadelphia">PA - Philadelphia</option>
         <option id="location" name="location" value="pa_allentown">PA - Allentown</option>
         <option id="location" name="location" value="russia_moscow">RUSSIA - Moscow</option>
         <option id="location" name="location" value="russia_stpetersburg">RUSSIA - St. Petersburg</option>
                 
            </select></div>
     <div><input name="submit" id="submit" value="submit" type="submit"></input></div>
    </form>

and here is the php for the form.

Code:

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<title>Untitled Document</title>
</head>

<body>

<?php 
if(isset($_POST['submit'])) { 
$to = "derekpainter1@hotmail.com"; 
$subject = "Flower Events Mailer"; 

foreach($_POST as $key => $value) {  /*loops through the POST array and uses the form values*/
  $$key = $value;
}
  
$body = "From: $name\n E-Mail: $email \n Message:  $message \n Location: $location \n Phone: $phone"; 
  
echo "Thank you for contacting Flower Events!"; 
mail($to, $subject, $body); 
} else { 
echo "blarg!"; 
} 
?>

</body>
</html>

[ramee001]

on the php of the form, try this

Code:

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<title>Untitled Document</title>
</head>

<body>

<?php 
if(isset($_POST['submit'])) { 
$to = "derekpainter1@hotmail.com"; 
$subject = "Flower Events Mailer"; 

foreach($_POST as $key => $value) {  /*loops through the POST array and uses the form values - This is very insecure and lazy.*/
  $key = $value; // changed this line. their was two $'s
}
  
$body = "From: $name\n E-Mail: $email \n Message:  $message \n Location: $location \n Phone: $phone"; 
  
echo "Thank you for contacting Flower Events!"; 
mail($to, $subject, $body); 
} else { 
echo "blarg!"; 
} 
?>

</body>
</html>

Code:

Add_Talkupation('rogem002'); // Because sharing is awesome! 

[Michael]

If you cannot see the difference, this is wrong in your code:

Code:

  $$key = $value;